netdev - Re: [PATCH iproute2 v5 1/2] ip-xfrm: Fix getprotobynumber() result to be print for each call.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191216204726.1659235f@hermes.lan>
Date:   Mon, 16 Dec 2019 20:47:26 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     "mizuta.takeshi@...itsu.com" <mizuta.takeshi@...itsu.com>
Cc:     "'netdev@...r.kernel.org'" <netdev@...r.kernel.org>,
        "'davem@...emloft.net'" <davem@...emloft.net>
Subject: Re: [PATCH iproute2 v5 1/2] ip-xfrm: Fix getprotobynumber() result
 to be print for each call.

On Mon, 16 Dec 2019 04:01:03 +0000
"mizuta.takeshi@...itsu.com" <mizuta.takeshi@...itsu.com> wrote:

> Running "ip xfrm state help" shows wrong protocol.
> 
>   $ ip xfrm state help
>   <snip>
>   UPSPEC := proto { { tcp | tcp | tcp | tcp } [ sport PORT ] [ dport PORT ] |
>                   { icmp | icmp | icmp } [ type NUMBER ] [ code NUMBER ] |
> 
> In order to get the character string from the protocol number, getprotobynumber(3) is called.
> However, since the address obtained by getprotobynumber(3) is static,
> it is necessary to print a character string each time getprotobynumber(3) is called.
> 
> Signed-off-by: MIZUTA Takeshi <mizuta.takeshi@...itsu.com>

These two patches do not apply to current git version of iproute2.