netdev - Re: [PATCH v2 bpf-next 3/3] bpftool: add gen subcommand manpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191218030525.lhxuieceglidv3jf@ast-mbp.dhcp.thefacebook.com>
Date:   Tue, 17 Dec 2019 19:05:27 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andriin@...com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...com,
        daniel@...earbox.net, andrii.nakryiko@...il.com, kernel-team@...com
Subject: Re: [PATCH v2 bpf-next 3/3] bpftool: add gen subcommand manpage

On Tue, Dec 17, 2019 at 03:00:38PM -0800, Andrii Nakryiko wrote:
> Add bpftool-gen.rst describing skeleton on the high level. Also include
> a small, but complete, example BPF app (BPF side, userspace side, generated
> skeleton) in example section to demonstrate skeleton API and its usage.
> 
> Acked-by: Yonghong Song <yhs@...com>
> Signed-off-by: Andrii Nakryiko <andriin@...com>
> ---
>  .../bpf/bpftool/Documentation/bpftool-gen.rst | 302 ++++++++++++++++++

Please test it more thoroughly.

  GEN      bpftool-gen.8
bpftool-gen.rst:244: (ERROR/3) Unexpected indentation.
bpftool-gen.rst:285: (ERROR/3) Unexpected indentation.

Patch 1 probably needs foo(void) instead of just foo().
I think some compilers warn on it.