netdev - Re: [PATCH v2 bpf-next 3/3] bpftool: add gen subcommand manpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzayD4Luv3=LivvJo3XK3+PNhjsd5T0B8p8JJ=T1dQspmg@mail.gmail.com>
Date:   Tue, 17 Dec 2019 21:22:41 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v2 bpf-next 3/3] bpftool: add gen subcommand manpage

On Tue, Dec 17, 2019 at 7:05 PM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Tue, Dec 17, 2019 at 03:00:38PM -0800, Andrii Nakryiko wrote:
> > Add bpftool-gen.rst describing skeleton on the high level. Also include
> > a small, but complete, example BPF app (BPF side, userspace side, generated
> > skeleton) in example section to demonstrate skeleton API and its usage.
> >
> > Acked-by: Yonghong Song <yhs@...com>
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
> > ---
> >  .../bpf/bpftool/Documentation/bpftool-gen.rst | 302 ++++++++++++++++++
>
> Please test it more thoroughly.
>
>   GEN      bpftool-gen.8
> bpftool-gen.rst:244: (ERROR/3) Unexpected indentation.
> bpftool-gen.rst:285: (ERROR/3) Unexpected indentation.

yep, my bad, didn't realize there is Makefile I'm supposed to run...

Fixed those two errors, reStructuredText is strict about code blocks.

>
> Patch 1 probably needs foo(void) instead of just foo().
> I think some compilers warn on it.
>

Added. Also simplified xxx__create_skeleton() a bit.