netdev - Re: [PATCH] tools lib api fs: fix gcc9 compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191218044043.GB88635@google.com>
Date:   Wed, 18 Dec 2019 13:40:43 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:     Andrey Zhizhikin <andrey.z@...il.com>, ast@...nel.org,
        daniel@...earbox.net, kafai@...com, songliubraving@...com,
        yhs@...com, andriin@...com, pmladek@...e.com,
        wangkefeng.wang@...wei.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        Andrey Zhizhikin <andrey.zhizhikin@...ca-geosystems.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Jiri Olsa <jolsa@...nel.org>
Subject: Re: [PATCH] tools lib api fs: fix gcc9 compilation error

On (19/12/18 12:10), Sergey Senozhatsky wrote:
> On (19/12/11 08:01), Andrey Zhizhikin wrote:
> [..]
> > @@ -210,6 +210,7 @@ static bool fs__env_override(struct fs *fs)
> >  	size_t name_len = strlen(fs->name);
> >  	/* name + "_PATH" + '\0' */
> >  	char upper_name[name_len + 5 + 1];
> > +
> >  	memcpy(upper_name, fs->name, name_len);
> >  	mem_toupper(upper_name, name_len);
> >  	strcpy(&upper_name[name_len], "_PATH");
> > @@ -219,7 +220,8 @@ static bool fs__env_override(struct fs *fs)
> >  		return false;
> >  
> >  	fs->found = true;
> > -	strncpy(fs->path, override_path, sizeof(fs->path));
> > +	strncpy(fs->path, override_path, sizeof(fs->path) - 1);
> > +	fs->path[sizeof(fs->path) - 1] = '\0';
> 
> I think the trend these days is to prefer stracpy/strscpy over
> strcpy/strlcpy/strncpy.

Scratch that. This is user-space, I should pay more attention.

	-ss