netdev - Re: [PATCH net-next v2] sch_cake: drop unused variable tin_quantum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B194F90A-7910-45B8-A8C0-6DAAA4ED7829@darbyshire-bryant.me.uk>
Date:   Wed, 18 Dec 2019 21:12:41 +0000
From:   Kevin 'ldir' Darbyshire-Bryant <ldir@...byshire-bryant.me.uk>
To:     David Miller <davem@...emloft.net>
CC:     "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2] sch_cake: drop unused variable
 tin_quantum_prio



> On 18 Dec 2019, at 20:37, David Miller <davem@...emloft.net> wrote:
> 
> From: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Date: Wed, 18 Dec 2019 09:53:40 -0800
> 
>> On Wed, 18 Dec 2019 14:05:13 +0000, Kevin 'ldir' Darbyshire-Bryant
>> wrote:
>>> Turns out tin_quantum_prio isn't used anymore and is a leftover from a
>>> previous implementation of diffserv tins.  Since the variable isn't used
>>> in any calculations it can be eliminated.
>>> 
>>> Drop variable and places where it was set.  Rename remaining variable
>>> and consolidate naming of intermediate variables that set it.
>>> 
>>> Signed-off-by: Kevin Darbyshire-Bryant <ldir@...byshire-bryant.me.uk>
>> 
>> Checkpatch sayeth:
>> 
>> WARNING: Missing Signed-off-by: line by nominal patch author 'Kevin 'ldir' Darbyshire-Bryant <ldir@...byshire-bryant.me.uk>'
> 
> Which is kinda rediculous wouldn't you say? :-)
> 
> The warning stops to be useful if it's going to be applied in situations
> like this where merely a nickname 'ldir' is added to the middle of the
> person's formal name.
> 
> I would never push back on a patch on these grounds, it just wastes time.

Hi David,

Thanks for that.  It has prompted confusion/investigation at my end to work
why exchange is inserting the alias into the from field though!  Think I’ve
worked that out and will try plan B on the next patch submission.

:-)

Kevin

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)