netdev - Re: [PATCH] net-sysfs: Call dev_hold always in rx_queue_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191217.225741.945639333059506658.davem@davemloft.net>
Date:   Tue, 17 Dec 2019 22:57:41 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jouni.hogander@...kie.com
Cc:     netdev@...r.kernel.org, penguin-kernel@...ove.SAKURA.ne.jp,
        lukas.bulwahn@...il.com
Subject: Re: [PATCH] net-sysfs: Call dev_hold always in rx_queue_add_kobject

From: jouni.hogander@...kie.com
Date: Tue, 17 Dec 2019 13:46:34 +0200

> From: Jouni Hogander <jouni.hogander@...kie.com>
> 
> Dev_hold has to be called always in rx_queue_add_kobject.
> Otherwise usage count drops below 0 in case of failure in
> kobject_init_and_add.
> 
> Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
> Reported-by: syzbot <syzbot+30209ea299c09d8785c9@...kaller.appspotmail.com>
> Cc: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Cc: David Miller <davem@...emloft.net>
> Cc: Lukas Bulwahn <lukas.bulwahn@...il.com>
> Signed-off-by: Jouni Hogander <jouni.hogander@...kie.com>

Applied and queued up for -stable.