netdev - Re: [PATCH net-next v2 2/7] net: stmmac: Always arm TX Timer at end of transmission start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191217.230111.26076810894427486.davem@davemloft.net>
Date:   Tue, 17 Dec 2019 23:01:11 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     Jose.Abreu@...opsys.com
Cc:     netdev@...r.kernel.org, Joao.Pinto@...opsys.com,
        jakub.kicinski@...ronome.com, peppe.cavallaro@...com,
        alexandre.torgue@...com, mcoquelin.stm32@...il.com,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/7] net: stmmac: Always arm TX Timer at
 end of transmission start

From: Jose Abreu <Jose.Abreu@...opsys.com>
Date: Tue, 17 Dec 2019 13:46:06 +0100

> If TX Coalesce timer is enabled we should always arm it, otherwise we
> may hit the case where an interrupt is missed and the TX Queue will
> timeout.
> 
> Arming the timer does not necessarly mean it will run the tx_clean()
> because this function is wrapped around NAPI launcher.
> 
> Signed-off-by: Jose Abreu <Jose.Abreu@...opsys.com>

This is a bug fix and thus appropriate for net not net-next.