lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Dec 2019 09:57:19 -0500 From: Jamal Hadi Salim <jhs@...atatu.com> To: Vlad Buslov <vladbu@...lanox.com> Cc: Davide Caratti <dcaratti@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, Roman Mashak <mrv@...atatu.com> Subject: Re: [PATCH net 1/2] net/sched: cls_u32: fix refcount leak in the error path of u32_change() On 2019-12-20 9:04 a.m., Vlad Buslov wrote: > > Hi Jamal, > > Yes, I think the patch would work. However, we don't really need the > flags check, if we are going to implement the new ops->delete_empty() > callback because it can work like this: > > if (!tp->ops->delete_empty) { > tp->deleting = true; > return tp->deleting; > } else { > return tp->ops->delete_empty(tp); > } > > WDYT? Looks reasonable - we kill two birds with one stone. We'd need to revert the patch David took in. cheers, jamal
Powered by blists - more mailing lists