netdev - Re: [PATCH net 1/2] net/sched: cls_u32: fix refcount leak in the error path of u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Dec 2019 16:20:47 +0100
From:   Davide Caratti <dcaratti@...hat.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>,
        Vlad Buslov <vladbu@...lanox.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>, Roman Mashak <mrv@...atatu.com>
Subject: Re: [PATCH net 1/2] net/sched: cls_u32: fix refcount leak in the
 error path of u32_change()

On Fri, 2019-12-20 at 09:57 -0500, Jamal Hadi Salim wrote:
> On 2019-12-20 9:04 a.m., Vlad Buslov wrote:
> > Hi Jamal,
> > 
> > Yes, I think the patch would work. However, we don't really need the
> > flags check, if we are going to implement the new ops->delete_empty()
> > callback because it can work like this:
> > 
> > if (!tp->ops->delete_empty) {
> >     tp->deleting = true;
> >     return tp->deleting;
> > } else {
> >    return tp->ops->delete_empty(tp);
> > }
> > 
> > WDYT?
> 
> Looks reasonable - we kill two birds with one stone.
> We'd need to revert the patch David took in.
> 
> cheers,
> jamal

... ok, I can try to do a series that reverts the fix on cls_u32 and
implements the check_delete_empty for cls_flower. You might find it above
the christmas tree (*)?

-- 
davide 

(*) above, not under, because the tree is reversed.