netdev - Re: [PATCH V6 net-next 06/11] net: Introduce a new MII time stamping interface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 20 Dec 2019 15:11:27 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     richardcochran@...il.com, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, f.fainelli@...il.com,
        hkallweit1@...il.com, jacob.e.keller@...el.com,
        mark.rutland@....com, mlichvar@...hat.com, m-karicheri2@...com,
        robh+dt@...nel.org, willemb@...gle.com, w-kwok2@...com
Subject: Re: [PATCH V6 net-next 06/11] net: Introduce a new MII time
 stamping interface.

From: Andrew Lunn <andrew@...n.ch>
Date: Fri, 20 Dec 2019 16:33:59 +0100

> On Fri, Dec 20, 2019 at 06:57:12AM -0800, Richard Cochran wrote:
>> On Tue, Dec 17, 2019 at 10:21:55AM +0100, Andrew Lunn wrote:
>> > Forward declarations are considered bad.
>> 
>> Not by me!
> 
> Lets see what David says.

I strongly dislike them too, it's indicative of poorly organized code.

It's pointless and avoidable clutter, and always when they exist people
never remember to remove them as code gets re-organized in the future.

Yeah, avoid forward declarations for sure.