netdev - Re: [PATCH bpf-next 0/6] Enhancements to xdpsock application

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 20 Dec 2019 16:12:20 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Björn Töpel <bjorn.topel@...il.com>
Cc:     Jay Jayatheerthan <jay.jayatheerthan@...el.com>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Björn Töpel <bjorn.topel@...el.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Netdev <netdev@...r.kernel.org>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next 0/6] Enhancements to xdpsock application

On Fri, Dec 20, 2019 at 2:04 AM Björn Töpel <bjorn.topel@...il.com> wrote:
>
> On Fri, 20 Dec 2019 at 09:55, Jay Jayatheerthan
> <jay.jayatheerthan@...el.com> wrote:
> >
> > This series of patches enhances xdpsock application with command line
> > parameters to set transmit packet size and fill pattern among other options.
> > The application has also been enhanced to use Linux Ethernet/IP/UDP header
> > structs and calculate IP and UDP checksums.
> >
> > I have measured the performance of the xdpsock application before and after
> > this patch set and have not been able to detect any difference.
> >
> > Packet Size:
> > ------------
> > There is a new option '-s' or '--tx-pkt-size' to specify the transmit packet
> > size. It ranges from 47 to 4096 bytes. Default packet size is 64 bytes
> > which is same as before.
> >
> > Fill Pattern:
> > -------------
> > The transmit UDP payload fill pattern is specified using '-P' or
> > '--tx-pkt-pattern'option. It is an unsigned 32 bit field and defaulted
> > to 0x12345678.
> >
> > Packet Count:
> > -------------
> > The number of packets to send is specified using '-C' or '--tx-pkt-count'
> > option. If it is not specified, the application sends packets forever.
> >
> > Batch Size:
> > -----------
> > The batch size for transmit, receive and l2fwd features of the application is
> > specified using '-b' or '--batch-size' options. Default value when this option
> > is not provided is 64 (same as before).
> >
> > Duration:
> > ---------
> > The application supports '-d' or '--duration' option to specify number of
> > seconds to run. This is used in tx, rx and l2fwd features. If this option is
> > not provided, the application runs for ever.
> >
> > This patchset has been applied against commit 99cacdc6f661f50f
> > ("Merge branch 'replace-cg_bpf-prog'")
> >
>
> Thanks for the hard work! I really like the synchronous cleanup! My
> scripts are already using the '-d' flag!
>
> For the series:
> Tested-by: Björn Töpel <bjorn.topel@...el.com>
> Acked-by: Björn Töpel <bjorn.topel@...el.com>

Applied. Thanks