netdev - Re: [PATCH bpf] samples/bpf: xdp_redirect_cpu fix missing tracepoint attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191221001446.6zjqrgmbnec7tsyu@ast-mbp.dhcp.thefacebook.com>
Date:   Fri, 20 Dec 2019 16:14:47 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Jesper Dangaard Brouer <brouer@...hat.com>,
        bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Maciek Fijałkowski 
        <maciejromanfijalkowski@...il.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Björn Töpel <bjorn.topel@...el.com>
Subject: Re: [PATCH bpf] samples/bpf: xdp_redirect_cpu fix missing tracepoint
 attach

On Fri, Dec 20, 2019 at 09:44:42AM -0800, Andrii Nakryiko wrote:
> On Fri, Dec 20, 2019 at 8:19 AM Jesper Dangaard Brouer
> <brouer@...hat.com> wrote:
> >
> > When sample xdp_redirect_cpu was converted to use libbpf, the
> > tracepoints used by this sample were not getting attached automatically
> > like with bpf_load.c. The BPF-maps was still getting loaded, thus
> > nobody notice that the tracepoints were not updating these maps.
> >
> > This fix doesn't use the new skeleton code, as this bug was introduced
> > in v5.1 and stable might want to backport this. E.g. Red Hat QA uses
> > this sample as part of their testing.
> >
> > Fixes: bbaf6029c49c ("samples/bpf: Convert XDP samples to libbpf usage")
> > Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
> > ---
> 
> Acked-by: Andrii Nakryiko <andriin@...com>

Applied to bpf-next. Thanks