netdev - Re: [GIT] Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whpoNwcb2fXH3e=pFjY1Tjb9rHLVjq_q-OzK3FMgvx2wA@mail.gmail.com>
Date:   Fri, 27 Dec 2019 14:13:03 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     David Miller <davem@...emloft.net>,
        Antoine Tenart <antoine.tenart@...tlin.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT] Networking

On Sat, Dec 21, 2019 at 6:09 PM David Miller <davem@...emloft.net> wrote:
>
> Antoine Tenart (2):
>       of: mdio: export of_mdiobus_child_is_phy

I didn't notice until now (bad me - I've actually been taking a few
days off due to xmas), but this causes a new warning in some
configurations.

In particular, it causes a warning about

   'of_mdiobus_child_is_phy' defined but noy used

because when CONFIG_OF_MDIO is disabled, the <linux/of_mdio.h> header now has

  static bool of_mdiobus_child_is_phy(struct device_node *child)
  {
         return false;
  }

which is all kinds of stupid.

I'm assuming that dummy function should just be marked "inline", the
way the other helper dummy functions are defined when OF_MDIO is not
enabled.

                 Linus