netdev - Re: [GIT] Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191227.142203.849415745093767537.davem@davemloft.net>
Date:   Fri, 27 Dec 2019 14:22:03 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     torvalds@...ux-foundation.org
Cc:     antoine.tenart@...tlin.com, akpm@...ux-foundation.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT] Networking

From: Linus Torvalds <torvalds@...ux-foundation.org>
Date: Fri, 27 Dec 2019 14:13:03 -0800

> I didn't notice until now (bad me - I've actually been taking a few
> days off due to xmas), but this causes a new warning in some
> configurations.
> 
> In particular, it causes a warning about
> 
>    'of_mdiobus_child_is_phy' defined but noy used
> 
> because when CONFIG_OF_MDIO is disabled, the <linux/of_mdio.h> header now has
> 
>   static bool of_mdiobus_child_is_phy(struct device_node *child)
>   {
>          return false;
>   }
> 
> which is all kinds of stupid.
> 
> I'm assuming that dummy function should just be marked "inline", the
> way the other helper dummy functions are defined when OF_MDIO is not
> enabled.

Yeah I have this fixed in my tree, I'll push that to you soon.

Thanks.