netdev - Re: [PATCH v2 net 0/2] The DSA TX timestamping situation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 28 Dec 2019 11:43:58 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     jakub.kicinski@...ronome.com, richardcochran@...il.com,
        f.fainelli@...il.com, vivien.didelot@...il.com, andrew@...n.ch,
        claudiu.manoil@....com, yangbo.lu@....com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net 0/2] The DSA TX timestamping situation

From: Vladimir Oltean <olteanv@...il.com>
Date: Sat, 28 Dec 2019 15:30:44 +0200

> This series is the moral v2 of "[PATCH net] net: dsa: sja1105: Fix
> double delivery of TX timestamps to socket error queue" [0] which did
> not manage to convince public opinion (actually it didn't convince me
> neither).
> 
> This fixes PTP timestamping on one particular board, where the DSA
> switch is sja1105 and the master is gianfar. Unfortunately there is no
> way to make the fix more general without committing logical
> inaccuracies: the SKBTX_IN_PROGRESS flag does serve a purpose, even if
> the sja1105 driver is not using it now: it prevents delivering a SW
> timestamp to the app socket when the HW timestamp will be provided. So
> not setting this flag (the approach from v1) might create avoidable
> complications in the future (not to mention that there isn't any
> satisfactory explanation on why that would be the correct solution).
> 
> So the goal of this change set is to create a more strict framework for
> DSA master devices when attached to PTP switches, and to fix the first
> master driver that is overstepping its duties and is delivering
> unsolicited TX timestamps.
> 
> [0]: https://www.spinics.net/lists/netdev/msg619699.html

Series applied, thank you.