netdev - Re: [PATCH] Improved handling of incorrect IP fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191228.115738.611834296697018444.davem@davemloft.net>
Date:   Sat, 28 Dec 2019 11:57:38 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ttttabcd@...tonmail.com
Cc:     netdev@...r.kernel.org, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] Improved handling of incorrect IP fragments

From: Ttttabcd <ttttabcd@...tonmail.com>
Date: Sat, 28 Dec 2019 16:10:03 +0000

> @@ -111,6 +110,7 @@ static int ip6_frag_queue(struct frag_queue *fq, struct sk_buff *skb,
>  	struct net_device *dev;
>  	int err = -ENOENT;
>  	u8 ecn;
> +	u32 prob_offset = 0;
> 
>  	if (fq->q.flags & INET_FRAG_COMPLETE)
>  		goto err;

Please preserve the reverse christmas tree ordering of local variables
here.

Also, I don't think "Ttttabcd" is a real name.

The patch signoff is a legally binding certification, so you must
use your real name.

Explicitly in Documentation/process/submitting-patches.rst it states:

--------------------
By making a contribution to this project, I certify that:
 ...
then you just add a line saying::

	Signed-off-by: Random J Developer <random@...eloper.example.org>

using your real name (sorry, no pseudonyms or anonymous contributions.)
--------------------

Thank you.