netdev - Re: [PATCH net] cxgb4/cxgb4vf: fix flow control display for auto negotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191230.144131.1699488284422282142.davem@davemloft.net>
Date:   Mon, 30 Dec 2019 14:41:31 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     rahul.lakkireddy@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com, vishal@...lsio.com,
        dt@...lsio.com, surendra@...lsio.com
Subject: Re: [PATCH net] cxgb4/cxgb4vf: fix flow control display for auto
 negotiation

From: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Date: Mon, 30 Dec 2019 18:14:08 +0530

> As per 802.3-2005, Section Two, Annex 28B, Table 28B-2 [1], when
> _only_ Rx pause is enabled, both symmetric and asymmetric pause
> towards local device must be enabled. Also, firmware returns the local
> device's flow control pause params as part of advertised capabilities
> and negotiated params as part of current link attributes. So, fix up
> ethtool's flow control pause params fetch logic to read from acaps,
> instead of linkattr.
> 
> [1] https://standards.ieee.org/standard/802_3-2005.html
> 
> Fixes: c3168cabe1af ("cxgb4/cxgbvf: Handle 32-bit fw port capabilities")
> Signed-off-by: Surendra Mobiya <surendra@...lsio.com>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>

Applied and queued up for -stable, thanks.