netdev - Re: [PATCH net] tcp_cubic: refactor code to perform a divide only when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191230.144530.870155928947538046.davem@davemloft.net>
Date:   Mon, 30 Dec 2019 14:45:30 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, soheil@...gle.com,
        ncardwell@...gle.com, ycheng@...gle.com, kafai@...com
Subject: Re: [PATCH net] tcp_cubic: refactor code to perform a divide only
 when needed

From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 30 Dec 2019 06:06:19 -0800

> Neal Cardwell suggested to not change ca->delay_min
> and apply the ack delay cushion only when Hystart ACK train
> is still under consideration. This should avoid a 64bit
> divide unless needed.
 ...
> Fixes: 42f3a8aaae66 ("tcp_cubic: tweak Hystart detection for short RTT flows")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Neal Cardwell <ncardwell@...gle.com>
> Link: https://www.spinics.net/lists/netdev/msg621886.html
> Link: https://www.spinics.net/lists/netdev/msg621797.html

Applied to net-next, since that's where the Fixes tag commit actually
lives.

Thanks.