netdev - Re: [PATCH net] net: dsa: sja1105: Remove restriction of zero base-time for taprio offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191230.201339.552516920501359150.davem@davemloft.net>
Date:   Mon, 30 Dec 2019 20:13:39 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     jakub.kicinski@...ronome.com, richardcochran@...il.com,
        f.fainelli@...il.com, vivien.didelot@...il.com, andrew@...n.ch,
        vinicius.gomes@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: sja1105: Remove restriction of zero
 base-time for taprio offload

From: Vladimir Oltean <olteanv@...il.com>
Date: Fri, 27 Dec 2019 03:03:54 +0200

> The check originates from the initial implementation which was not based
> on PTP time but on a standalone clock source. In the meantime we can now
> program the PTPSCHTM register at runtime with the dynamic base time
> (actually with a value that is 200 ns smaller, to avoid writing DELTA=0
> in the Schedule Entry Points Parameters Table). And we also have logic
> for moving the actual base time in the future of the PHC's current time
> base, so the check for zero serves no purpose, since even if the user
> will specify zero, that's not what will end up in the static config
> table where the limitation is.
> 
> Fixes: 86db36a347b4 ("net: dsa: sja1105: Implement state machine for TAS with PTP clock source")
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Applied.