netdev - Re: [PATCH net] net: dsa: sja1105: Really make the PTP command read-write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Dec 2019 20:12:03 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     jakub.kicinski@...ronome.com, richardcochran@...il.com,
        f.fainelli@...il.com, vivien.didelot@...il.com, andrew@...n.ch,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: sja1105: Really make the PTP command
 read-write

From: Vladimir Oltean <olteanv@...il.com>
Date: Fri, 27 Dec 2019 03:01:50 +0200

> When activating tc-taprio offload on the switch ports, the TAS state
> machine will try to check whether it is running or not, but will find
> both the STARTED and STOPPED bits as false in the
> sja1105_tas_check_running function. So the function will return -EINVAL
> (an abnormal situation) and the kernel will keep printing this from the
> TAS FSM workqueue:
> 
> [   37.691971] sja1105 spi0.1: An operation returned -22
> 
> The reason is that the underlying function that gets called,
> sja1105_ptp_commit, does not actually do a SPI_READ, but a SPI_WRITE. So
> the command buffer remains initialized with zeroes instead of retrieving
> the hardware state. Fix that.
> 
> Fixes: 41603d78b362 ("net: dsa: sja1105: Make the PTP command read-write")
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Applied, thanks.