netdev - Re: [PATCH] tcp: Fix highest_sack and highest_sack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191230.202946.2283077363010869071.davem@davemloft.net>
Date:   Mon, 30 Dec 2019 20:29:46 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     cambda@...ux.alibaba.com
Cc:     edumazet@...gle.com, ycheng@...gle.com, netdev@...r.kernel.org,
        dust.li@...ux.alibaba.com
Subject: Re: [PATCH] tcp: Fix highest_sack and highest_sack_seq

From: Cambda Zhu <cambda@...ux.alibaba.com>
Date: Fri, 27 Dec 2019 16:52:37 +0800

> From commit 50895b9de1d3 ("tcp: highest_sack fix"), the logic about
> setting tp->highest_sack to the head of the send queue was removed.
> Of course the logic is error prone, but it is logical. Before we
> remove the pointer to the highest sack skb and use the seq instead,
> we need to set tp->highest_sack to NULL when there is no skb after
> the last sack, and then replace NULL with the real skb when new skb
> inserted into the rtx queue, because the NULL means the highest sack
> seq is tp->snd_nxt. If tp->highest_sack is NULL and new data sent,
> the next ACK with sack option will increase tp->reordering unexpectedly.
> 
> This patch sets tp->highest_sack to the tail of the rtx queue if
> it's NULL and new data is sent. The patch keeps the rule that the
> highest_sack can only be maintained by sack processing, except for
> this only case.
> 
> Fixes: 50895b9de1d3 ("tcp: highest_sack fix")
> Signed-off-by: Cambda Zhu <cambda@...ux.alibaba.com>

Applied and queued up for -stable, thanks.