netdev - Re: [PATCH net-next 2/2] net: switch to using PHY_INTERFACE_MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200103204102.GI25745@shell.armlinux.org.uk>
Date:   Fri, 3 Jan 2020 20:41:02 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jonathan Corbet <corbet@....net>,
        Kishon Vijay Abraham I <kishon@...com>,
        linux-doc@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: switch to using
 PHY_INTERFACE_MODE_10GBASER rather than 10GKR

On Fri, Jan 03, 2020 at 09:25:04PM +0100, Andrew Lunn wrote:
> > For Marvell mvpp2, we detect 10GBASE-KR, and rewrite it to 10GBASE-R
> > for compatibility with existing DT - this is the only network driver
> > at present that makes use of PHY_INTERFACE_MODE_10GKR.
> > 
> > Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>
> > @@ -5247,6 +5247,9 @@ static int mvpp2_port_probe(struct platform_device *pdev,
> >  		goto err_free_netdev;
> >  	}
> >  
> > +	if (phy_mode == PHY_INTERFACE_MODE_10GKR)
> > +		phy_mode = PHY_INTERFACE_MODE_10GBASER;
> 
> Hi Russell
> 
> Maybe consider adding a comment here, or suggest readers to read the
> commit message of the patch that added these two lines to get the full
> story.

It's a bit difficult to refer to the commit SHA in the commit itself,
but yes, that's a good idea. I'll send v2 shortly.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up