lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 05 Jan 2020 14:25:31 -0800 (PST) From: David Miller <davem@...emloft.net> To: f.fainelli@...il.com Cc: netdev@...r.kernel.org, alobakin@...nk.ru, rmk+kernel@...linux.org.uk, andrew@...n.ch, vivien.didelot@...il.com, hauke@...ke-m.de, woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com, sean.wang@...iatek.com, matthias.bgg@...il.com, vladimir.oltean@....com, claudiu.manoil@....com, sdf@...gle.com, daniel@...earbox.net, songliubraving@...com, ppenkov@...gle.com, mcroce@...hat.com, jakub@...udflare.com, edumazet@...gle.com, paulb@...lanox.com, komachi.yoshiki@...il.com, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org Subject: Re: [PATCH net-next] net: dsa: Remove indirect function call for flow dissection From: Florian Fainelli <f.fainelli@...il.com> Date: Thu, 2 Jan 2020 15:36:53 -0800 > We only need "static" information to be given for DSA flow dissection, > so replace the expensive call to .flow_dissect() with an integer giving > us the offset into the packet array of bytes that we must de-reference > to obtain the protocol number. The overhead was alreayd available from > the dsa_device_ops structure so use that directly. > > The presence of a flow_dissect callback used to indicate that the DSA > tagger supported returning that information,we now encode this with a > proto_off value of DSA_PROTO_OFF_UNPSEC if the tagger does not support > providing that information yet. > > Signed-off-by: Florian Fainelli <f.fainelli@...il.com> > --- > Changes since RFC: > > - use a constant instead of the "magic" -1 > - update all tag drivers and build test correctly At the very least the typos need to be fixed, so marking this changes requested in patchwork just FYI...
Powered by blists - more mailing lists