netdev - Re: [Linux-stm32] [PATCH net] net: stmmac: Fixed link does not need MDIO Bus

Open Source and information security mailing list archives

Message-ID: <4330eb5a-1dfa-783c-69c9-35692db65341@st.com>
Date:   Tue, 7 Jan 2020 13:30:14 +0000
From:   Patrice CHOTARD <patrice.chotard@...com>
To:     Sriram Dash <sriram.dash@...sung.com>,
        'Jose Abreu' <Jose.Abreu@...opsys.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     'Joao Pinto' <Joao.Pinto@...opsys.com>,
        "'kernelci . org bot'" <bot@...nelci.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "'David S. Miller'" <davem@...emloft.net>,
        'Florian Fainelli' <f.fainelli@...il.com>,
        'Maxime Coquelin' <mcoquelin.stm32@...il.com>,
        Peppe CAVALLARO <peppe.cavallaro@...com>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        'Heiko Stuebner' <heiko@...ech.de>
Subject: Re: [Linux-stm32] [PATCH net] net: stmmac: Fixed link does not need
 MDIO Bus

Hi All

On 1/7/20 1:51 PM, Sriram Dash wrote:
>> From: Jose Abreu <Jose.Abreu@...opsys.com>
>> Subject: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
>>
>> When using fixed link we don't need the MDIO bus support.
>>
>> Reported-by: Heiko Stuebner <heiko@...ech.de>
>> Reported-by: kernelci.org bot <bot@...nelci.org>
>> Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms
>> without PHY")
>> Signed-off-by: Jose Abreu <Jose.Abreu@...opsys.com>
> Acked-by: Sriram Dash <Sriram.dash@...sung.com>

Tested on STiH410-B2260 board

Tested-by: Patrice Chotard <patrice.chotard@...com>

Thanks

>> ---
>> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>
>> Cc: Alexandre Torgue <alexandre.torgue@...com>
>> Cc: Jose Abreu <joabreu@...opsys.com>
>> Cc: "David S. Miller" <davem@...emloft.net>
>> Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>
>> Cc: netdev@...r.kernel.org
>> Cc: linux-stm32@...md-mailman.stormreply.com
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Cc: linux-kernel@...r.kernel.org
>> Cc: Heiko Stuebner <heiko@...ech.de>
>> Cc: kernelci.org bot <bot@...nelci.org>
>> Cc: Florian Fainelli <f.fainelli@...il.com>
>> Cc: Sriram Dash <sriram.dash@...sung.com>
>> ---
>>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> index cc8d7e7bf9ac..4775f49d7f3b 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> @@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device
>> *pdev,  static int stmmac_dt_phy(struct plat_stmmacenet_data *plat,
>>  			 struct device_node *np, struct device *dev)  {
>> -	bool mdio = false;
>> +	bool mdio = !of_phy_is_fixed_link(np);
>>  	static const struct of_device_id need_mdio_ids[] = {
>>  		{ .compatible = "snps,dwc-qos-ethernet-4.10" },
>>  		{},
>> --
>> 2.7.4
>
> _______________________________________________
> Linux-stm32 mailing list
> Linux-stm32@...md-mailman.stormreply.com
> https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives