netdev - RE: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <014201d5c559$3e6204b0$bb260e10$@samsung.com>
Date:   Tue, 7 Jan 2020 18:21:52 +0530
From:   "Sriram Dash" <sriram.dash@...sung.com>
To:     "'Jose Abreu'" <Jose.Abreu@...opsys.com>, <netdev@...r.kernel.org>
Cc:     "'Joao Pinto'" <Joao.Pinto@...opsys.com>,
        "'Giuseppe Cavallaro'" <peppe.cavallaro@...com>,
        "'Alexandre Torgue'" <alexandre.torgue@...com>,
        "'David S. Miller'" <davem@...emloft.net>,
        "'Maxime Coquelin'" <mcoquelin.stm32@...il.com>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        "'Heiko Stuebner'" <heiko@...ech.de>,
        "'kernelci . org bot'" <bot@...nelci.org>,
        "'Florian Fainelli'" <f.fainelli@...il.com>
Subject: RE: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus

> From: Jose Abreu <Jose.Abreu@...opsys.com>
> Subject: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
> 
> When using fixed link we don't need the MDIO bus support.
> 
> Reported-by: Heiko Stuebner <heiko@...ech.de>
> Reported-by: kernelci.org bot <bot@...nelci.org>
> Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms
> without PHY")
> Signed-off-by: Jose Abreu <Jose.Abreu@...opsys.com>

Acked-by: Sriram Dash <Sriram.dash@...sung.com>

> 
> ---
> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>
> Cc: Alexandre Torgue <alexandre.torgue@...com>
> Cc: Jose Abreu <joabreu@...opsys.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>
> Cc: netdev@...r.kernel.org
> Cc: linux-stm32@...md-mailman.stormreply.com
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: kernelci.org bot <bot@...nelci.org>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Sriram Dash <sriram.dash@...sung.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index cc8d7e7bf9ac..4775f49d7f3b 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device
> *pdev,  static int stmmac_dt_phy(struct plat_stmmacenet_data *plat,
>  			 struct device_node *np, struct device *dev)  {
> -	bool mdio = false;
> +	bool mdio = !of_phy_is_fixed_link(np);
>  	static const struct of_device_id need_mdio_ids[] = {
>  		{ .compatible = "snps,dwc-qos-ethernet-4.10" },
>  		{},
> --
> 2.7.4