netdev - Re: [PATCH V2] net: 3com: 3c59x: remove set but not used variable 'mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Jan 2020 13:59:29 -0800
From:   Matthew Wilcox <willy@...radead.org>
To:     David Miller <davem@...emloft.net>
Cc:     yukuai3@...wei.com, klassert@...nel.org, hkallweit1@...il.com,
        jakub.kicinski@...ronome.com, hslester96@...il.com, mst@...hat.com,
        yang.wei9@....com.cn, netdev@...r.kernel.org, yi.zhang@...wei.com,
        zhengbin13@...wei.com
Subject: Re: [PATCH V2] net: 3com: 3c59x: remove set but not used variable
 'mii_reg1'

On Wed, Jan 08, 2020 at 12:40:21PM -0800, David Miller wrote:
> From: yu kuai <yukuai3@...wei.com>
> Date: Mon, 6 Jan 2020 20:53:37 +0800
> 
> > Fixes gcc '-Wunused-but-set-variable' warning:
> > 
> > drivers/net/ethernet/3com/3c59x.c: In function ‘vortex_up’:
> > drivers/net/ethernet/3com/3c59x.c:1551:9: warning: variable
> > ‘mii_reg1’ set but not used [-Wunused-but-set-variable]
> > 
> > It is never used, and so can be removed.
> > 
> > Signed-off-by: yu kuai <yukuai3@...wei.com>
> > ---
> > changes in V2
> > -The read might have side effects, don't remove it.
> 
> Applied to net-next, thank you.

This waas a mistaken version; please revert and apply v3 instead.