netdev - Re: [PATCH nf] netfilter: conntrack: dccp, sctp: handle null timeout argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200108223214.3niyo2o2sr2zf3fg@salvia>
Date:   Wed, 8 Jan 2020 23:32:14 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Florian Westphal <fw@...len.de>
Cc:     netfilter-devel@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzbot+46a4ad33f345d1dd346e@...kaller.appspotmail.com
Subject: Re: [PATCH nf] netfilter: conntrack: dccp, sctp: handle null timeout
 argument

On Mon, Jan 06, 2020 at 11:34:17PM +0100, Florian Westphal wrote:
> The timeout pointer can be NULL which means we should modify the
> per-nets timeout instead.
> 
> All do this, except sctp and dccp which instead give:
> 
> general protection fault: 0000 [#1] PREEMPT SMP KASAN
> net/netfilter/nf_conntrack_proto_dccp.c:682
>  ctnl_timeout_parse_policy+0x150/0x1d0 net/netfilter/nfnetlink_cttimeout.c:67
>  cttimeout_default_set+0x150/0x1c0 net/netfilter/nfnetlink_cttimeout.c:368
>  nfnetlink_rcv_msg+0xcf2/0xfb0 net/netfilter/nfnetlink.c:229
>  netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477

Applied, thanks Florian.