netdev - Re: [PATCH] [net-next] [v2] socket: fix unused-function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200108.150240.1372285867204858318.davem@davemloft.net>
Date:   Wed, 08 Jan 2020 15:02:40 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     ktkhai@...tuozzo.com, viro@...iv.linux.org.uk, axboe@...nel.dk,
        willemb@...gle.com, deepa.kernel@...il.com,
        johannes.berg@...el.com, pctammela@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [net-next] [v2] socket: fix unused-function warning

From: Arnd Bergmann <arnd@...db.de>
Date: Wed,  8 Jan 2020 22:44:43 +0100

> When procfs is disabled, the fdinfo code causes a harmless
> warning:
> 
> net/socket.c:1000:13: error: 'sock_show_fdinfo' defined but not used [-Werror=unused-function]
>  static void sock_show_fdinfo(struct seq_file *m, struct file *f)
> 
> Move the function definition up so we can use a single #ifdef
> around it.
> 
> Fixes: b4653342b151 ("net: Allow to show socket-specific information in /proc/[pid]/fdinfo/[fd]")
> Suggested-by: Al Viro <viro@...iv.linux.org.uk>
> Acked-by: Kirill Tkhai <ktkhai@...tuozzo.com>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks Arnd.