netdev - Re: [PATCH V2] net: 3com: 3c59x: remove set but not used variable 'mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5dacc18-b93f-3760-966a-c36d058139e3@huawei.com>
Date:   Thu, 9 Jan 2020 09:14:16 +0800
From:   "yukuai (C)" <yukuai3@...wei.com>
To:     Matthew Wilcox <willy@...radead.org>,
        David Miller <davem@...emloft.net>
CC:     <klassert@...nel.org>, <hkallweit1@...il.com>,
        <jakub.kicinski@...ronome.com>, <hslester96@...il.com>,
        <mst@...hat.com>, <yang.wei9@....com.cn>, <netdev@...r.kernel.org>,
        <yi.zhang@...wei.com>, <zhengbin13@...wei.com>
Subject: Re: [PATCH V2] net: 3com: 3c59x: remove set but not used variable
 'mii_reg1'



On 2020/1/9 9:03, Matthew Wilcox wrote:

> v2:
> -               mii_reg1 = mdio_read(dev, vp->phys[0], MII_BMSR);
> 
> v3:
> -               mii_reg1 = mdio_read(dev, vp->phys[0], MII_BMSR);
> +               mdio_read(dev, vp->phys[0], MII_BMSR);

Yes, V2 was a mistaken, my bad.
Please apply v3 instead.

Thanks!
Yu Kuai