netdev - Re: [PATCH V2] net: 3com: 3c59x: remove set but not used variable 'mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200108.175500.179307969610909253.davem@davemloft.net>
Date:   Wed, 08 Jan 2020 17:55:00 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     willy@...radead.org
Cc:     yukuai3@...wei.com, klassert@...nel.org, hkallweit1@...il.com,
        jakub.kicinski@...ronome.com, hslester96@...il.com, mst@...hat.com,
        yang.wei9@....com.cn, netdev@...r.kernel.org, yi.zhang@...wei.com,
        zhengbin13@...wei.com
Subject: Re: [PATCH V2] net: 3com: 3c59x: remove set but not used variable
 'mii_reg1'

From: Matthew Wilcox <willy@...radead.org>
Date: Wed, 8 Jan 2020 17:03:44 -0800

> On Wed, Jan 08, 2020 at 03:05:49PM -0800, David Miller wrote:
>> From: Matthew Wilcox <willy@...radead.org>
>> Date: Wed, 8 Jan 2020 13:59:29 -0800
>> 
>> > This waas a mistaken version; please revert and apply v3 instead.
>> 
>> Are you sure?
>> 
>> [davem@...alhost net-next]$ git show e102774588b3ac0d221ed2d03a5153e056f1354f >x.diff
>> [davem@...alhost net-next]$ patch -p1 -R <x.diff 
>> patching file drivers/net/ethernet/3com/3c59x.c
>> [davem@...alhost net-next]$ mv ~/Downloads/V3-net-3com-3c59x-remove-set-but-not-used-variable-mii_reg1.patch ./
>> [davem@...alhost net-next]$ patch -p1 <V3-net-3com-3c59x-remove-set-but-not-used-variable-mii_reg1.patch 
>> patching file drivers/net/ethernet/3com/3c59x.c
>> [davem@...alhost net-next]$ git diff
>> [davem@...alhost net-next]$
>> 
>> There is no difference in the code of the commit at all between V2 and V3.
> 
> v2:
> -               mii_reg1 = mdio_read(dev, vp->phys[0], MII_BMSR);
> 
> v3:
> -               mii_reg1 = mdio_read(dev, vp->phys[0], MII_BMSR);
> +               mdio_read(dev, vp->phys[0], MII_BMSR);

Then check what is in the GIT tree I probably applied V3 and replied accidently
to V2 :-)