netdev - Re: [PATCH] sfc/ethtool_common: Make some function to static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4e97682-1ac2-e563-af52-4889cb2e639f@solarflare.com>
Date:   Mon, 13 Jan 2020 13:29:13 +0000
From:   Martin Habets <mhabets@...arflare.com>
To:     Zhang Xiaoxu <zhangxiaoxu5@...wei.com>,
        <linux-net-drivers@...arflare.com>, <ecree@...arflare.com>,
        <amaftei@...arflare.com>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>
Subject: Re: [PATCH] sfc/ethtool_common: Make some function to static

On 13/01/2020 11:24, Zhang Xiaoxu wrote:
> Fix sparse warning:
> 
> drivers/net/ethernet/sfc/ethtool_common.c
>   warning: symbol 'efx_fill_test' was not declared. Should it be static?
>   warning: symbol 'efx_fill_loopback_test' was not declared.
>            Should it be static?
>   warning: symbol 'efx_describe_per_queue_stats' was not declared.
>            Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@...wei.com>

Good catch. Thanks!

Reviewed-by: Martin Habets <mhabets@...arflare.com>

> ---
>  drivers/net/ethernet/sfc/ethtool_common.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/ethtool_common.c b/drivers/net/ethernet/sfc/ethtool_common.c
> index 3d7f75cc5cf0..b8d281ab6c7a 100644
> --- a/drivers/net/ethernet/sfc/ethtool_common.c
> +++ b/drivers/net/ethernet/sfc/ethtool_common.c
> @@ -147,9 +147,9 @@ void efx_ethtool_get_pauseparam(struct net_device *net_dev,
>   *
>   * Fill in an individual self-test entry.
>   */
> -void efx_fill_test(unsigned int test_index, u8 *strings, u64 *data,
> -		   int *test, const char *unit_format, int unit_id,
> -		   const char *test_format, const char *test_id)
> +static void efx_fill_test(unsigned int test_index, u8 *strings, u64 *data,
> +			  int *test, const char *unit_format, int unit_id,
> +			  const char *test_format, const char *test_id)
>  {
>  	char unit_str[ETH_GSTRING_LEN], test_str[ETH_GSTRING_LEN];
>  
> @@ -189,10 +189,11 @@ void efx_fill_test(unsigned int test_index, u8 *strings, u64 *data,
>   * Fill in a block of loopback self-test entries.  Return new test
>   * index.
>   */
> -int efx_fill_loopback_test(struct efx_nic *efx,
> -			   struct efx_loopback_self_tests *lb_tests,
> -			   enum efx_loopback_mode mode,
> -			   unsigned int test_index, u8 *strings, u64 *data)
> +static int efx_fill_loopback_test(struct efx_nic *efx,
> +				  struct efx_loopback_self_tests *lb_tests,
> +				  enum efx_loopback_mode mode,
> +				  unsigned int test_index,
> +				  u8 *strings, u64 *data)
>  {
>  	struct efx_channel *channel =
>  		efx_get_channel(efx, efx->tx_channel_offset);
> @@ -293,7 +294,7 @@ int efx_ethtool_fill_self_tests(struct efx_nic *efx,
>  	return n;
>  }
>  
> -size_t efx_describe_per_queue_stats(struct efx_nic *efx, u8 *strings)
> +static size_t efx_describe_per_queue_stats(struct efx_nic *efx, u8 *strings)
>  {
>  	size_t n_stats = 0;
>  	struct efx_channel *channel;
>