netdev - Re: [PATCH] sfc/ethtool_common: Make some function to static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c1a0337-3665-79bc-b275-6a2d0b8389c1@solarflare.com>
Date:   Mon, 13 Jan 2020 13:29:42 +0000
From:   Martin Habets <mhabets@...arflare.com>
To:     Jakub Kicinski <kubakici@...pl>, <ecree@...arflare.com>,
        <amaftei@...arflare.com>
CC:     Zhang Xiaoxu <zhangxiaoxu5@...wei.com>,
        <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] sfc/ethtool_common: Make some function to static

Hi Jakub,

The fix is good. Even when we reuse this code these functions can remain static.

Martin

On 13/01/2020 12:58, Jakub Kicinski wrote:
> On Mon, 13 Jan 2020 19:24:11 +0800, Zhang Xiaoxu wrote:
>> Fix sparse warning:
>>
>> drivers/net/ethernet/sfc/ethtool_common.c
>>   warning: symbol 'efx_fill_test' was not declared. Should it be static?
>>   warning: symbol 'efx_fill_loopback_test' was not declared.
>>            Should it be static?
>>   warning: symbol 'efx_describe_per_queue_stats' was not declared.
>>            Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@...wei.com>
> 
> Ed, Alex, since you were talking about reusing this code would you
> rather add a declaration for these function to a header? Or should 
> I apply the current fix?
>