lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 14 Jan 2020 12:07:46 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Michal Kalderon <mkalderon@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     Jiri Pirko <jiri@...lanox.com>, Ariel Elior <aelior@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>
Subject: Re: [EXT] [PATCH 11/17] devlink: add a driver-specific file for the
 qed driver

On 1/14/2020 12:41 AM, Michal Kalderon wrote:
>> From: Jacob Keller <jacob.e.keller@...el.com>
>> Sent: Friday, January 10, 2020 12:46 AM
>> +
>> +Parameters
>> +==========
>> +
>> +The ``qed`` driver implements the following driver-specific parameters.
>> +
>> +.. list-table:: Driver-specific parameters implemented
>> +   :widths: 5 5 5 85
>> +
>> +   * - Name
>> +     - Type
>> +     - Mode
>> +     - Description
>> +   * - ``iwarp_cmt``
>> +     - Boolean
>> +     - runtime
>> +     - Enable iWARP functionality for 100g devices. Notee that this impacts
>> +       L2 performance, and is therefor not enabled by default.
> Small typos: Note instead of Notee and therefore instead of therefor
> Other than that looks great, thanks a lot for adding this. 
> 
> Michal
I think this got merged. I'll go ahead and send a follow-up patch to
clean those up. Nice catch!

Regards,
Jake

Powered by blists - more mailing lists