netdev - RE: [EXT] [PATCH 11/17] devlink: add a driver-specific file for the qed driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR18MB3182A8390BC9D7883ED5A18BA1340@MN2PR18MB3182.namprd18.prod.outlook.com>
Date:   Tue, 14 Jan 2020 08:41:06 +0000
From:   Michal Kalderon <mkalderon@...vell.com>
To:     Jacob Keller <jacob.e.keller@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Jiri Pirko <jiri@...lanox.com>, Ariel Elior <aelior@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>
Subject: RE: [EXT] [PATCH 11/17] devlink: add a driver-specific file for the
 qed driver

> From: Jacob Keller <jacob.e.keller@...el.com>
> Sent: Friday, January 10, 2020 12:46 AM
> 
> External Email
> 
> ----------------------------------------------------------------------
> The qed driver recently added devlink support with a single devlink
> parameter. Add a driver-specific file to document the devlink features that
> the qed driver supports.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Cc: Ariel Elior <aelior@...vell.com>
> Cc: GR-everest-linux-l2@...vell.com
> ---
>  Documentation/networking/devlink/index.rst |  1 +
>  Documentation/networking/devlink/qed.rst   | 26
> ++++++++++++++++++++++
>  2 files changed, 27 insertions(+)
>  create mode 100644 Documentation/networking/devlink/qed.rst
> 
> diff --git a/Documentation/networking/devlink/index.rst
> b/Documentation/networking/devlink/index.rst
> index 0cbafef607d8..2007e257fd8a 100644
> --- a/Documentation/networking/devlink/index.rst
> +++ b/Documentation/networking/devlink/index.rst
> @@ -34,4 +34,5 @@ parameters, info versions, and other features it
> supports.
>     mlxsw
>     mv88e6xxx
>     nfp
> +   qed
>     ti-cpsw-switch
> diff --git a/Documentation/networking/devlink/qed.rst
> b/Documentation/networking/devlink/qed.rst
> new file mode 100644
> index 000000000000..e7e17acf1eca
> --- /dev/null
> +++ b/Documentation/networking/devlink/qed.rst
> @@ -0,0 +1,26 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +===================
> +qed devlink support
> +===================
> +
> +This document describes the devlink features implemented by the ``qed``
> +core device driver.
> +
> +Parameters
> +==========
> +
> +The ``qed`` driver implements the following driver-specific parameters.
> +
> +.. list-table:: Driver-specific parameters implemented
> +   :widths: 5 5 5 85
> +
> +   * - Name
> +     - Type
> +     - Mode
> +     - Description
> +   * - ``iwarp_cmt``
> +     - Boolean
> +     - runtime
> +     - Enable iWARP functionality for 100g devices. Notee that this impacts
> +       L2 performance, and is therefor not enabled by default.
Small typos: Note instead of Notee and therefore instead of therefor
Other than that looks great, thanks a lot for adding this. 

Michal
> --
> 2.25.0.rc1