netdev - Re: [PATCH net] macvlan: use skb_reset_mac_header() in macvlan_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGnkfhx-V2xrRCbyjzZtiap0-gqQ+nDvf2E-5mRFZM8LVQLqWg@mail.gmail.com>
Date:   Wed, 15 Jan 2020 02:38:20 +0100
From:   Matteo Croce <mcroce@...hat.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Jurgen Van Ham <juvanham@...il.com>
Subject: Re: [PATCH net] macvlan: use skb_reset_mac_header() in macvlan_queue_xmit()

On Tue, Jan 14, 2020 at 10:01 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> I missed the fact that macvlan_broadcast() can be used both
> in RX and TX.
>
> skb_eth_hdr() makes only sense in TX paths, so we can not
> use it blindly in macvlan_broadcast()
>
> Fixes: 96cc4b69581d ("macvlan: do not assume mac_header is set in macvlan_broadcast()")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Jurgen Van Ham <juvanham@...il.com>

Tested-by: Matteo Croce <mcroce@...hat.com>

-- 
Matteo Croce
per aspera ad upstream