netdev - Re: [PATCH net] macvlan: use skb_reset_mac_header() in macvlan_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200116.041402.757321430890945981.davem@davemloft.net>
Date:   Thu, 16 Jan 2020 04:14:02 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, juvanham@...il.com
Subject: Re: [PATCH net] macvlan: use skb_reset_mac_header() in
 macvlan_queue_xmit()

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue, 14 Jan 2020 13:00:35 -0800

> I missed the fact that macvlan_broadcast() can be used both
> in RX and TX.
> 
> skb_eth_hdr() makes only sense in TX paths, so we can not
> use it blindly in macvlan_broadcast()
> 
> Fixes: 96cc4b69581d ("macvlan: do not assume mac_header is set in macvlan_broadcast()")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Jurgen Van Ham <juvanham@...il.com>

Applied and queued up for -stable, thanks Eric.