netdev - Re: [PATCH] net: wan: lapbether.c: Use built-in RCU list checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200116.053107.2118682332070479073.davem@davemloft.net>
Date:   Thu, 16 Jan 2020 05:31:07 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     madhuparnabhowmik04@...il.com
Cc:     gregkh@...uxfoundation.org, paulmck@...nel.org,
        joel@...lfernandes.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, rcu@...r.kernel.org,
        frextrite@...il.com
Subject: Re: [PATCH] net: wan: lapbether.c: Use built-in RCU list checking

From: madhuparnabhowmik04@...il.com
Date: Wed, 15 Jan 2020 17:11:01 +0530

> From: Madhuparna Bhowmik <madhuparnabhowmik04@...il.com>
> 
> The only callers of the function lapbeth_get_x25_dev()
> are lapbeth_rcv() and lapbeth_device_event().
> 
> lapbeth_rcv() uses rcu_read_lock() whereas lapbeth_device_event()
> is called with RTNL held (As mentioned in the comments).
> 
> Therefore, pass lockdep_rtnl_is_held() as cond argument in
> list_for_each_entry_rcu();
> 
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@...il.com>

Applied.