netdev - Re: [PATCH -next] mac80111: fix build error without CONFIG_ATH11K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <943b570c-48f9-fe5b-1691-37539e3eeec8@huawei.com>
Date:   Thu, 16 Jan 2020 21:35:44 +0800
From:   Chen Zhou <chenzhou10@...wei.com>
To:     Johannes Berg <johannes@...solutions.net>, <davem@...emloft.net>
CC:     <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] mac80111: fix build error without
 CONFIG_ATH11K_DEBUGFS

Hi johannes,

On 2020/1/16 20:59, Johannes Berg wrote:
> On Thu, 2020-01-16 at 20:51 +0800, Chen Zhou wrote:
>> If CONFIG_ATH11K_DEBUGFS is n, build fails:
>>
>> drivers/net/wireless/ath/ath11k/debugfs_sta.c: In function ath11k_dbg_sta_open_htt_peer_stats:
>> drivers/net/wireless/ath/ath11k/debugfs_sta.c:416:4: error: struct ath11k has no member named debug
>>   ar->debug.htt_stats.stats_req = stats_req;
>>       ^~
>> and many more similar messages.
>>
>> Select ATH11K_DEBUGFS under config MAC80211_DEBUGFS to fix this.
> 
> Heh, no. You need to find a way in ath11 to fix this.

In file drivers/net/wireless/ath/ath11k/Makefile, "ath11k-$(CONFIG_MAC80211_DEBUGFS) += debugfs_sta.o",
that is, debugfs_sta only compiled when CONFIG_MAC80211_DEBUGFS is y.

Any suggestions about this?

Thanks,
Chen Zhou

> 
> johannes
> 
> 
> .
>