netdev - Re: [PATCH -next] mac80111: fix build error without CONFIG_ATH11K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87lfq7zf8r.fsf@tynnyri.adurom.net>
Date:   Thu, 16 Jan 2020 15:45:56 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Chen Zhou <chenzhou10@...wei.com>
Cc:     Johannes Berg <johannes@...solutions.net>, <davem@...emloft.net>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, ath11k@...ts.infradead.org
Subject: Re: [PATCH -next] mac80111: fix build error without CONFIG_ATH11K_DEBUGFS

+ ath11k

Chen Zhou <chenzhou10@...wei.com> writes:

> Hi johannes,
>
> On 2020/1/16 20:59, Johannes Berg wrote:
>> On Thu, 2020-01-16 at 20:51 +0800, Chen Zhou wrote:
>>> If CONFIG_ATH11K_DEBUGFS is n, build fails:
>>>
>>> drivers/net/wireless/ath/ath11k/debugfs_sta.c: In function ath11k_dbg_sta_open_htt_peer_stats:
>>> drivers/net/wireless/ath/ath11k/debugfs_sta.c:416:4: error: struct ath11k has no member named debug
>>>   ar->debug.htt_stats.stats_req = stats_req;
>>>       ^~
>>> and many more similar messages.
>>>
>>> Select ATH11K_DEBUGFS under config MAC80211_DEBUGFS to fix this.
>> 
>> Heh, no. You need to find a way in ath11 to fix this.
>
> In file drivers/net/wireless/ath/ath11k/Makefile, "ath11k-$(CONFIG_MAC80211_DEBUGFS) += debugfs_sta.o",
> that is, debugfs_sta only compiled when CONFIG_MAC80211_DEBUGFS is y.
>
> Any suggestions about this?

Arnd already fixed this:

https://patchwork.kernel.org/patch/11321921/

I'm planning to apply the patch soon.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches