lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Jan 2020 14:43:30 +0100 From: Andrew Lunn <andrew@...n.ch> To: Alexandru Ardelean <alexandru.ardelean@...log.com> Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, davem@...emloft.net, f.fainelli@...il.com, hkallweit1@...il.com Subject: Re: [PATCH 4/4] dt-bindings: net: adin: document 1588 TX/RX SOP bindings > + adi,1588-rx-sop-delays-cycles: > + allOf: > + - $ref: /schemas/types.yaml#definitions/uint8-array > + - items: > + - minItems: 3 > + maxItems: 3 > + description: | > + Enables Start Packet detection (SOP) for received IEEE 1588 time stamp > + controls, and configures the number of cycles (of the MII RX_CLK clock) > + to delay the indication of RX SOP frames for 10/100/1000 BASE-T links. > + The first element (in the array) configures the delay for 10BASE-T, > + the second for 100BASE-T, and the third for 1000BASE-T. Do you know the clock frequency? It would be much better to express this in ns, as with adi,1588-tx-sop-delays-ns. > @@ -62,5 +116,11 @@ examples: > reg = <1>; > > adi,fifo-depth-bits = <16>; > + > + adi,1588-rx-sop-delays-cycles = [ 00 00 00 ]; > + adi,1588-rx-sop-pin-name = "int_n"; > + > + adi,1588-tx-sop-delays-ns = [ 00 08 10 ]; 10 is not a multiple of 8! Andrew
Powered by blists - more mailing lists