netdev - Re: [EXT] Re: [v1,net-next, 1/2] ethtool: add setting frame preemption of traffic classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8736cd4pdz.fsf@linux.intel.com>
Date:   Fri, 17 Jan 2020 15:47:04 -0800
From:   Vinicius Costa Gomes <vinicius.gomes@...el.com>
To:     Murali Karicheri <m-karicheri2@...com>,
        Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
Cc:     Po Liu <po.liu@....com>,
        Andre Guedes <andre.guedes@...ux.intel.com>,
        "alexandru.ardelean\@analog.com" <alexandru.ardelean@...log.com>,
        "allison\@lohutok.net" <allison@...utok.net>,
        "andrew\@lunn.ch" <andrew@...n.ch>,
        "ayal\@mellanox.com" <ayal@...lanox.com>,
        "davem\@davemloft.net" <davem@...emloft.net>,
        "f.fainelli\@gmail.com" <f.fainelli@...il.com>,
        "gregkh\@linuxfoundation.org" <gregkh@...uxfoundation.org>,
        "hauke.mehrtens\@intel.com" <hauke.mehrtens@...el.com>,
        "hkallweit1\@gmail.com" <hkallweit1@...il.com>,
        "jiri\@mellanox.com" <jiri@...lanox.com>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
        "pablo\@netfilter.org" <pablo@...filter.org>,
        "saeedm\@mellanox.com" <saeedm@...lanox.com>,
        "tglx\@linutronix.de" <tglx@...utronix.de>,
        Vladimir Oltean <vladimir.oltean@....com>,
        "simon.horman\@netronome.com" <simon.horman@...ronome.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandru Marginean <alexandru.marginean@....com>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        Roy Zang <roy.zang@....com>, Mingkai Hu <mingkai.hu@....com>,
        Jerry Huang <jerry.huang@....com>, Leo Li <leoyang.li@....com>
Subject: Re: [EXT] Re: [v1,net-next, 1/2] ethtool: add setting frame preemption of traffic classes

Hi,

Murali Karicheri <m-karicheri2@...com> writes:

[...]

>>>
>>> 2) What if I want to use frame preemption with another "transmission selection
>>> algorithm"? Say another one "time sensitive" - CBS? How is it going to be
>>> stacked?
>> 
>> I am not seeing any (conceptual*) problems when plugging a cbs (for
>> example) qdisc into one of taprio children. Or, are you talking about a
>> more general problem?
>> 
>
> If I understand it correctly problem is not stacking taprio with cbs,
> but rather pre-emption with other qdiscs and allow configuring
> the parameters such as frag size. How do I use frame pre-emption as
> an independent feature and configure frag size? Ethool appears to be
> better from this point of view as Ivan has mentioned below.
>

Yeah, after all the discussion here, I think we came to the rough
consensus that ethtool is the best place we have to enable/disable frame
preemption and its configuration knobs.

I just have a few comments to add to the series (sorry for the long
delay).


Cheers,
--
Vinicius