netdev - Re: [PATCH] net: ip6_gre: fix moving ip6gre between namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALDO+SZppBa6Wm+yi-UfQohzH3We3jWHZk5Ge8fTutH6VJHg7Q@mail.gmail.com>
Date:   Fri, 17 Jan 2020 15:52:15 -0800
From:   William Tu <u9012063@...il.com>
To:     nicolas.dichtel@...nd.com
Cc:     kortstro <niko.kortstrom@...ia.com>,
        David Miller <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: ip6_gre: fix moving ip6gre between namespaces

On Thu, Jan 16, 2020 at 8:00 AM Nicolas Dichtel
<nicolas.dichtel@...nd.com> wrote:
>
> + William Tu
>
> Le 16/01/2020 à 15:43, kortstro a écrit :
> > On 1/16/20 4:02 PM, Nicolas Dichtel wrote:
> >> Le 16/01/2020 à 10:43, Niko Kortstrom a écrit :
> >>> Support for moving IPv4 GRE tunnels between namespaces was added in
> >>> commit b57708add314 ("gre: add x-netns support"). The respective change
> >>> for IPv6 tunnels, commit 22f08069e8b4 ("ip6gre: add x-netns support")
> >>> did not drop NETIF_F_NETNS_LOCAL flag so moving them from one netns to
> >>> another is still denied in IPv6 case. Drop NETIF_F_NETNS_LOCAL flag from
> >>> ip6gre tunnels to allow moving ip6gre tunnel endpoints between network
> >>> namespaces.
> >>>
> >>> Signed-off-by: Niko Kortstrom <niko.kortstrom@...ia.com>
> >> LGTM.
> >> Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Hi Nicolas,

I did not test moving between namespaces at that time.
Your change looks good to me.

Acked-by: William Tu <u9012063@...il.com>

Thanks
William

> >>
> >> Did you test real x-vrf cases with the three kinds of gre interfaces
> >> (gre/collect_md, gretap and erspan)?
> > This was only verified in real use with ip6gretap.
> William, did you set this flag on collect_md interfaces because you did not test
> this feature or was it another reason?
>
> Note: the flag was added here: 6712abc168eb ("ip6_gre: add ip6 gre and gretap
> collect_md mode").
>
> Regards,
> Nicolas