netdev - RE: [PATCH bpf-next] selftests/bpf: don't check for btf fd in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e228d76ec631_4cb22afa407465c025@john-XPS-13-9370.notmuch>
Date:   Fri, 17 Jan 2020 20:45:42 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Stanislav Fomichev <sdf@...gle.com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Cc:     davem@...emloft.net, ast@...nel.org, daniel@...earbox.net,
        Stanislav Fomichev <sdf@...gle.com>
Subject: RE: [PATCH bpf-next] selftests/bpf: don't check for btf fd in
 test_btf

Stanislav Fomichev wrote:
> After commit 0d13bfce023a ("libbpf: Don't require root for
> bpf_object__open()") we no longer load BTF during bpf_object__open(),
> so let's remove the expectation from test_btf that the fd is not -1.
> The test currently fails.
> 
> Before:
> BTF libbpf test[1] (test_btf_haskv.o): do_test_file:4152:FAIL bpf_object__btf_fd: -1
> BTF libbpf test[2] (test_btf_newkv.o): do_test_file:4152:FAIL bpf_object__btf_fd: -1
> BTF libbpf test[3] (test_btf_nokv.o): do_test_file:4152:FAIL bpf_object__btf_fd: -1
> 
> After:
> BTF libbpf test[1] (test_btf_haskv.o): OK
> BTF libbpf test[2] (test_btf_newkv.o): OK
> BTF libbpf test[3] (test_btf_nokv.o): OK
> 
> Fixes: 0d13bfce023a ("libbpf: Don't require root forbpf_object__open()")
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>
> ---

Acked-by: John Fastabend <john.fastabend@...il.com>