netdev - Re: [PATCH] tc: parse attributes with NLA_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <263a272f-770e-6757-916b-49f1036a8954@gmail.com>
Date:   Sat, 18 Jan 2020 15:01:38 -0700
From:   David Ahern <dsahern@...il.com>
To:     Leslie Monis <lesliemonis@...il.com>,
        Linux NetDev <netdev@...r.kernel.org>
Cc:     David Ahern <dsahern@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH] tc: parse attributes with NLA_F_NESTED flag

On 1/16/20 8:57 AM, Leslie Monis wrote:

> diff --git a/tc/tc_class.c b/tc/tc_class.c
> index c7e3cfdf..39bea971 100644
> --- a/tc/tc_class.c
> +++ b/tc/tc_class.c
> @@ -246,8 +246,8 @@ static void graph_cls_show(FILE *fp, char *buf, struct hlist_head *root_list,
>  			 "+---(%s)", cls_id_str);
>  		strcat(buf, str);
>  
> -		parse_rtattr(tb, TCA_MAX, (struct rtattr *)cls->data,
> -				cls->data_len);
> +		parse_rtattr_flags(tb, TCA_MAX, (struct rtattr *)cls->data,
> +				   cls->data_len, NLA_F_NESTED);

Petr recently sent a patch to update parse_rtattr_nested to add the
NESTED flag. Can you update this patch to use parse_rtattr_nested?