netdev - Re: [PATCH net-next] net: dsa: felix: Set USXGMII link based on BMSR, not LPA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200117.041536.1247451269684567321.davem@davemloft.net>
Date:   Fri, 17 Jan 2020 04:15:36 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     netdev@...r.kernel.org, linux@...linux.org.uk, andrew@...n.ch,
        f.fainelli@...il.com, vivien.didelot@...il.com,
        claudiu.manoil@....com, alexandru.marginean@....com,
        vladimir.oltean@....com
Subject: Re: [PATCH net-next] net: dsa: felix: Set USXGMII link based on
 BMSR, not LPA

From: Vladimir Oltean <olteanv@...il.com>
Date: Thu, 16 Jan 2020 20:05:06 +0200

> From: Alex Marginean <alexandru.marginean@....com>
> 
> At least some PHYs (AQR412) don't advertise copper-side link status
> during system side AN.
> 
> So remove this duplicate assignment to pcs->link and rely on the
> previous one for link state: the local indication from the MAC PCS.
> 
> Fixes: bdeced75b13f ("net: dsa: felix: Add PCS operations for PHYLINK")
> Signed-off-by: Alex Marginean <alexandru.marginean@....com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Applied, thanks.