netdev - Re: [PATCH net-next] net: dsa: felix: Don't restart PCS SGMII AN if not needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200117.041815.1098432693191653265.davem@davemloft.net>
Date:   Fri, 17 Jan 2020 04:18:15 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     netdev@...r.kernel.org, linux@...linux.org.uk, andrew@...n.ch,
        f.fainelli@...il.com, vivien.didelot@...il.com,
        claudiu.manoil@....com, alexandru.marginean@....com,
        vladimir.oltean@....com
Subject: Re: [PATCH net-next] net: dsa: felix: Don't restart PCS SGMII AN
 if not needed

From: Vladimir Oltean <olteanv@...il.com>
Date: Thu, 16 Jan 2020 20:09:59 +0200

> From: Alex Marginean <alexandru.marginean@....com>
> 
> Some PHYs like VSC8234 don't like it when AN restarts on their system side
> and they restart line side AN too, going into an endless link up/down loop.
> Don't restart PCS AN if link is up already.
> 
> Although in theory this feedback loop should be possible with the other
> in-band AN modes too, for some reason it was not seen with the VSC8514
> QSGMII and AQR412 USXGMII PHYs. So keep this logic only for SGMII where
> the problem was found.
> 
> Fixes: bdeced75b13f ("net: dsa: felix: Add PCS operations for PHYLINK")
> Suggested-by: Vladimir Oltean <vladimir.oltean@....com>
> Signed-off-by: Alex Marginean <alexandru.marginean@....com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Applied.