netdev - RE: [PATCH bpf] selftests/bpf: skip perf hw events test if the setup disabled it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e2534ee4cf7b_3d922aba572005bc10@john-XPS-13-9370.notmuch>
Date:   Sun, 19 Jan 2020 21:04:46 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Song Liu <songliubraving@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Hangbin Liu <liuhangbin@...il.com>
Subject: RE: [PATCH bpf] selftests/bpf: skip perf hw events test if the setup
 disabled it

Hangbin Liu wrote:
> The same with commit 4e59afbbed96 ("selftests/bpf: skip nmi test when perf
> hw events are disabled"), it would make more sense to skip the
> test_stacktrace_build_id_nmi test if the setup (e.g. virtual machines) has
> disabled hardware perf events.
> 
> Fixes: 13790d1cc72c ("bpf: add selftest for stackmap with build_id in NMI context")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  .../selftests/bpf/prog_tests/stacktrace_build_id_nmi.c    | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/stacktrace_build_id_nmi.c b/tools/testing/selftests/bpf/prog_tests/stacktrace_build_id_nmi.c
> index f62aa0eb959b..437cb93e72ac 100644
> --- a/tools/testing/selftests/bpf/prog_tests/stacktrace_build_id_nmi.c
> +++ b/tools/testing/selftests/bpf/prog_tests/stacktrace_build_id_nmi.c
> @@ -49,8 +49,12 @@ void test_stacktrace_build_id_nmi(void)
>  	pmu_fd = syscall(__NR_perf_event_open, &attr, -1 /* pid */,
>  			 0 /* cpu 0 */, -1 /* group id */,
>  			 0 /* flags */);
> -	if (CHECK(pmu_fd < 0, "perf_event_open",
> -		  "err %d errno %d. Does the test host support PERF_COUNT_HW_CPU_CYCLES?\n",
> +	if (pmu_fd < 0 && errno == ENOENT) {
> +		printf("%s:SKIP:no PERF_COUNT_HW_CPU_CYCLES\n", __func__);
> +		test__skip();
> +		goto close_prog;
> +	}
> +	if (CHECK(pmu_fd < 0, "perf_event_open", "err %d errno %d\n",
>  		  pmu_fd, errno))
>  		goto close_prog;
>  

Acked-by: John Fastabend <john.fastabend@...il.com>