netdev - Re: [PATCH net] Revert "udp: do rmem bulk free even if the rx sk queue is empty"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTScNcdaP4dDmoXesfY1HwE7r1VSiG_SbhbwBNugbv9hAxg@mail.gmail.com>
Date:   Tue, 21 Jan 2020 13:26:02 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net] Revert "udp: do rmem bulk free even if the rx sk
 queue is empty"

On Tue, Jan 21, 2020 at 10:51 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> This reverts commit 0d4a6608f68c7532dcbfec2ea1150c9761767d03.
>
> Williem reported that after commit 0d4a6608f68c ("udp: do rmem bulk
> free even if the rx sk queue is empty") the memory allocated by
> an almost idle system with many UDP sockets can grow a lot.
>
> For stable kernel keep the solution as simple as possible and revert
> the offending commit.
>
> Reported-by: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Diagnosed-by: Eric Dumazet <eric.dumazet@...il.com>
> Fixes: 0d4a6608f68c ("udp: do rmem bulk free even if the rx sk queue is empty")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>

Thanks Paolo