netdev - Re: [PATCH net] Revert "udp: do rmem bulk free even if the rx sk queue is empty"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5be7e66-b809-094b-56d6-8c4c9bebf413@cogentembedded.com>
Date:   Wed, 22 Jan 2020 13:02:05 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net] Revert "udp: do rmem bulk free even if the rx sk
 queue is empty"

Hello!

On 21.01.2020 18:50, Paolo Abeni wrote:

> This reverts commit 0d4a6608f68c7532dcbfec2ea1150c9761767d03.
> 
> Williem reported that after commit 0d4a6608f68c ("udp: do rmem bulk

    Willem (as below)?

> free even if the rx sk queue is empty") the memory allocated by
> an almost idle system with many UDP sockets can grow a lot.
> 
> For stable kernel keep the solution as simple as possible and revert
> the offending commit.
> 
> Reported-by: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Diagnosed-by: Eric Dumazet <eric.dumazet@...il.com>
> Fixes: 0d4a6608f68c ("udp: do rmem bulk free even if the rx sk queue is empty")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
[...]

MBR, Sergei