netdev - Re: [PATCH net-next 1/4] net: bridge: check port state before br_allowed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B878D56B-BA6C-49A9-877D-5590BC4DC314@cumulusnetworks.com>
Date:   Thu, 23 Jan 2020 19:58:35 +0200
From:   nikolay@...ulusnetworks.com
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        davem@...emloft.net, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next 1/4] net: bridge: check port state before br_allowed_egress

On 23 January 2020 18:25:42 EET, Stephen Hemminger <stephen@...workplumber.org> wrote:
>On Thu, 23 Jan 2020 15:28:04 +0200
>Nikolay Aleksandrov <nikolay@...ulusnetworks.com> wrote:
>
>>  	return ((p->flags & BR_HAIRPIN_MODE) || skb->dev != p->dev) &&
>> -		br_allowed_egress(vg, skb) && p->state == BR_STATE_FORWARDING &&
>> +		p->state == BR_STATE_FORWARDING && br_allowed_egress(vg, skb) &&
>>  		nbp_switchdev_allowed_egress(p, skb) &&
>>  		!br_skb_isolated(p, skb);
>>  }
>
>Maybe break this complex return for readability?

Sure, sounds good, but is not the point of this commit. 
I'll prepare a separate cleanup patch for that. 

Thanks, 
  Nik